QAProcess: DevelopersGuide | Review Status | PackageProposalProcess | PackageDocumentation | APIReviewProcess | DocReviewProcess | CodeReviewProcess | StackDocumentation | StackVersionPolicy | AutomatedTesting | StackReleaseProcess | WritingTutorials | Graveyard
Doc Review means that your API has been cleared (see APIReviewProcess) and that all relevant documentation for all potential users (e.g. developers vs. casual users) has been reviewed. Packages, Stacks, and Apps can all be Doc Reviewed.
We also Doc Review thirdparty components. This requires different guidelines, which are outlined below.
Create a calendar event on Google Calendar, add guests
email@example.com, firstname.lastname@example.org, individuals whom you think should attend (not everybody is on ros-review)
Include a link to the Doc review page. Give at least 48 hours between sending out the review and the requested response.
- Is the description in the stack.xml informative? This shows up in the summary of the Stack wiki page.
- For the expected usages of your Stack, are the necessary APIs documented? (in other words, internal APIs do not need to be documented, some justification needs to be provided by the component owner as to what is/isn't internal)
- Do relevant usages have associated tutorials?
Have all Packages in the Stack been API reviewed?
- Is the documentation for these APIs correct? Look for typos, things that are out-of-date, ambiguities, omissions, etc...
Does the Stack conform to the StackDocumentation guidelines?
- Are there Packages in your Stack that don't belong
Doc Review for Packages can generally occur at the same time as the Stacks that they belong in, though there is nothing wrong with reviewing them ahead of time. They must have been API reviewed prior to this, however.
NOTE: while some of these questions are identical to questions about Stacks, the answers may in fact be different. For example, Stack tutorials address the aggregate usage of the Packages, whereas Package tutorials focus generally on just that Package.
- Is the description in the manifest.xml informative? This shows up in the summary at the top of the wiki page.
- Does the Wiki page properly introduce the user to the package. For example, if the package is a C++ library, does the wiki page guide the user to the C++ API. If the package contains a spec (e.g. URDF), is it easy to find and interact with that spec?
- Are there grey links in the Wiki sidebar that should be filled in, e.g. "Tutorials" and "Troubleshooting"?
- For the expected usages of the Package, are all of these APIs documented? (in other words, internal APIs do not need to be documented, some justification needs to be provided by the package owner as to what is/isn't internal)
- Do relevant usages have associated tutorials? (you can ignore this if a Stack-level tutorial covers the relevant usage)
- If there are hardware dependencies of your Package, are these documented?
- Is it clear to an outside user what the roadmap is for your Package? It's okay if this roadmap is on the Stack roadmap.
- Is it clear to an outside user what the stability is for your Package?
- Are concepts introduced by your Package well illustrated?
- Is the research related to your Package referenced properly? i.e. can users easily get to relevant papers?
- Are any mathematical formulas in your Package not covered by papers properly documented?
For each launch file in a Package
- Is it clear how to run that launch file?
- Does the launch file start up with no errors when run correctly?
- Do the Nodes in that launch file correctly use ROS_ERROR/ROS_WARN/ROS_INFO logging levels?
Once the package is Doc Reviewed, set the review status in the manifest to "doc reviewed".
Thirdparty Doc Review
Reviewing thirdparty Packages follows a slightly different process to acknowledge the fact that we don't have control over the API of these Packages. We still Doc Review these Packages as there are some important things to check before we release a thirdparty Package with a Stack.
In general, the answers to these questions should be available in the manifest of the Package
- Is the version that we're using correct?
- Is it clear to an outside user which version we're using, and why?
- What is the update policy for versions going forward?
- Is this package available from the OS package managers instead? There is a strong preference to using these instead of maintaining our own
- Have all patches been submitted back? What version do you expect these patches to be included in?
Once the package is Doc Reviewed, set the review status in the manifest to "3rdparty doc reviewed".
Completing a Review
If you have completed Doc Review, please mark the relevant manifest.xml or stack.xml with Doc reviewed in the <review> status. Also note the date of the review in the notes attribute.